Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Xoops Editor TinyMCE 5 #1053

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Xoops Editor TinyMCE 5 #1053

merged 5 commits into from
Sep 9, 2022

Conversation

ForXoops
Copy link
Contributor

@ForXoops ForXoops commented Jul 29, 2021

Update Mage version to the lastest version 5.8.2
Add Xoops Emoticons plugins
Add Xoops Image Manager plugin

Add Xoops Emoticons plugins
Add Xoops Image Manager plugin
@ForXoops ForXoops changed the title Update Mage version to the lastest version 5.8.2 Xoops Editor TinyMCE 5 Jul 29, 2021
@alain01
Copy link
Contributor

alain01 commented Jul 29, 2021

Amazing plugin for xoops image manager !
Great Job !
TY ForMus

@mambax7
Copy link
Collaborator

mambax7 commented Jul 31, 2021

I just tested it, and it works great! Awesome work, and a great help!
Thank you so much for doing it!

@mambax7
Copy link
Collaborator

mambax7 commented Jul 31, 2021

The only issue that I see is with code quoting.

When I insert code in the admin mode I see this:
image

but in the user mode, I see this:

image

How could we fix it?

@alain01
Copy link
Contributor

alain01 commented Jul 31, 2021

Yes, same problem here.

@ForXoops
Copy link
Contributor Author

ForXoops commented Aug 2, 2021

I am in holidays actually, but We need to add prism.js and prism.css from prismjs.com in the front-end to display the code render
I check for a fix next week.
Nicolas

@ForXoops
Copy link
Contributor Author

ForXoops commented Aug 2, 2021

See this link https://www.tiny.cloud/docs/plugins/opensource/codesample/

@mambax7
Copy link
Collaborator

mambax7 commented Aug 2, 2021

That would be awesome!!! Thank you so much!!!
In the meantime, enjoy your vacation!

Copy link
Contributor

@alain01 alain01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the css file (background color when I used T5)

padding-left: 5px;
}

@import url(css-cerulean/bootstrap.min.css);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IS it possible to read the css file automatically with XOOPS smarty ?
Cause if someone use dark theme, css-cerulean is not the good css file !

But Strange cause I used dark theme (slate theme) and the background, is the same dark background, not the cerulean background color.

Strange but it works ! ;-)

Bonnes vacances, Nicolas !

@geekwright
Copy link
Contributor

@ForXoops This is awesome! I am looking forward to merging your excellent work.

There was some mention of adding prisim,js, but I'm not sure if you were planning on adding that to this pull request.

I will merge it when you tell me it is ready.

@mambax7
Copy link
Collaborator

mambax7 commented Aug 31, 2022

@ForXoops Thank you so much for the update!!!

@mambax7 mambax7 requested a review from geekwright August 31, 2022 15:06
Copy link
Contributor

@geekwright geekwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @ForXoops

@geekwright geekwright merged commit 05d2ac9 into XOOPS:master Sep 9, 2022
@mambax7 mambax7 mentioned this pull request Dec 18, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants