Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Graceful shutdown #1801

Merged

Conversation

kuznetsss
Copy link
Collaborator

@kuznetsss kuznetsss commented Dec 20, 2024

Fixes #442.

@kuznetsss kuznetsss force-pushed the 442_Graceful_shutdown_with_new_server branch from 77db7fe to 7062d40 Compare December 20, 2024 17:13
Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some small suggestions. Looks pretty good 👍

src/app/Stopper.hpp Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/etl/impl/SubscriptionSource.cpp Outdated Show resolved Hide resolved
src/util/StopHelper.cpp Outdated Show resolved Hide resolved
src/util/StopHelper.cpp Show resolved Hide resolved
src/web/ng/Server.cpp Show resolved Hide resolved
src/app/ClioApplication.cpp Outdated Show resolved Hide resolved
@kuznetsss kuznetsss marked this pull request as ready for review January 9, 2025 17:50
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 67.29560% with 52 lines in your changes missing coverage. Please review.

Project coverage is 71.63%. Comparing base (12e6fcc) to head (6c52b65).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/app/Stopper.hpp 10.52% 0 Missing and 17 partials ⚠️
src/etl/impl/SubscriptionSource.cpp 72.41% 4 Missing and 4 partials ⚠️
src/web/ng/impl/ConnectionHandler.cpp 78.37% 1 Missing and 7 partials ⚠️
src/etl/ETLService.hpp 12.50% 7 Missing ⚠️
src/web/ng/Server.cpp 72.22% 4 Missing and 1 partial ⚠️
src/app/ClioApplication.cpp 0.00% 3 Missing ⚠️
src/web/ng/impl/HttpConnection.hpp 33.33% 1 Missing and 1 partial ⚠️
src/app/Stopper.cpp 90.90% 0 Missing and 1 partial ⚠️
src/etl/impl/SourceImpl.hpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
- Coverage    71.69%   71.63%   -0.06%     
===========================================
  Files          326      330       +4     
  Lines        13307    13413     +106     
  Branches      6761     6826      +65     
===========================================
+ Hits          9540     9608      +68     
- Misses        1913     1921       +8     
- Partials      1854     1884      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to consider that shutdown happens during cache loading?

Copy link
Collaborator

@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuznetsss kuznetsss merged commit 9570286 into XRPLF:develop Jan 22, 2025
17 checks passed
@kuznetsss kuznetsss deleted the 442_Graceful_shutdown_with_new_server branch January 22, 2025 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle SIGHUP and friends gracefully
3 participants