-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Graceful shutdown #1801
feat: Graceful shutdown #1801
Conversation
…tdown_with_new_server
…tdown_with_new_server
77db7fe
to
7062d40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some small suggestions. Looks pretty good 👍
…tdown_with_new_server
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1801 +/- ##
===========================================
- Coverage 71.69% 71.63% -0.06%
===========================================
Files 326 330 +4
Lines 13307 13413 +106
Branches 6761 6826 +65
===========================================
+ Hits 9540 9608 +68
- Misses 1913 1921 +8
- Partials 1854 1884 +30 ☔ View full report in Codecov by Sentry. |
…tdown_with_new_server
…tdown_with_new_server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to consider that shutdown happens during cache loading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #442.