fix: Data race in new webserver #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1926 +/- ##
===========================================
+ Coverage 72.71% 73.15% +0.43%
===========================================
Files 333 337 +4
Lines 13525 13819 +294
Branches 6881 7007 +126
===========================================
+ Hits 9835 10109 +274
+ Misses 1785 1783 -2
- Partials 1905 1927 +22 ☔ View full report in Codecov by Sentry. |
cindyyan317
approved these changes
Feb 27, 2025
PeterChen13579
pushed a commit
to PeterChen13579/clio
that referenced
this pull request
Mar 2, 2025
There was a data race inside `CoroutineGroup` because internal timer was used from multiple threads in the methods `asyncWait()` and `onCoroutineComplete()`. Changing `registerForeign()` to spawn to the same `yield_context` fixes the problem because now the timer is accessed only from the same coroutine which has an internal strand. During debugging I also added websocket support for `request_gun` tool.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a data race inside
CoroutineGroupbecause internal timer was used from multiple threads in the methodsasyncWait()andonCoroutineComplete(). ChangingregisterForeign()to spawn to the sameyield_contextfixes the problem because now the timer is accessed only from the same coroutine which has an internal strand.During debugging I also added websocket support for
request_guntool.