Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ValidatorSite): handle rare null pointer dereference in timeout #4420

Merged
merged 11 commits into from
Mar 16, 2023

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Feb 13, 2023

High Level Overview of Change

The title really says it all.

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)

* upstream/develop:
  Rename to fixNonFungibleTokensV1_2 and some cosmetic changes (XRPLF#4419)
  Only account specified as destination can settle through brokerage: (XRPLF#4399)
  Prevent brokered sale of NFToken to owner: (XRPLF#4403)
  Fix 3 issues around NFToken offer acceptance (XRPLF#4380)
  Allow NFT to be burned when number of offers is greater than 500 (XRPLF#4346)
  Add fixUnburnableNFToken feature (XRPLF#4391)
@intelliot intelliot added this to the 1.10.1 milestone Feb 15, 2023
* upstream/develop:
  Resolve a couple of Github Action CI annoyances: (XRPLF#4413)
* upstream/develop:
  README: Add a few source code starting points (XRPLF#4421)
* upstream/develop:
  Fix Conan version constraint in workflows (XRPLF#4430)
  Refactor getTrustedForLedger() (XRPLF#4424)
  README: Update "Build from source" section (XRPLF#4426)
* upstream/develop:
  Undo API changes introduced in XRPFees: (XRPLF#4429)
  Remove recipe for RocksDB and add recipe for Snappy (XRPLF#4431)
@intelliot intelliot requested a review from mtrippled March 1, 2023 17:48
Copy link
Collaborator

@mtrippled mtrippled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@intelliot intelliot added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 2, 2023
ximinez added 5 commits March 2, 2023 18:17
* upstream/develop:
  Update package building scripts and images to use Conan (XRPLF#4435)
  Disable duplicate detector: (XRPLF#4438)
* upstream/develop:
  Set version to 1.10.0-rc4
  Rename 'NFT' to 'NFToken' in DisallowIncoming flags (XRPLF#4442)
  Update Docker.md (XRPLF#4432)
* upstream/develop:
  docs: security bug bounty acknowledgements (XRPLF#4460)
* upstream/develop:
  Rectify the import paths of boost/iterator: (XRPLF#4293)
  Allow port numbers be be specified with a colon: (XRPLF#4328)
  Use <=> operator for base_uint, Issue, and Book: (XRPLF#4411)
  Reporting Mode: Do not attempt to acquire missing data from peer network (XRPLF#4458)
@intelliot intelliot changed the title Handle rare null pointer dereference in ValidatorSite timeout fix(ValidatorSite): handle rare null pointer dereference in timeout Mar 16, 2023
@intelliot intelliot merged commit 1c9df69 into XRPLF:develop Mar 16, 2023
@ximinez ximinez deleted the site-timeout branch March 16, 2023 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants