Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add browser dialer for splithttp #3484

Merged
merged 13 commits into from
Jul 11, 2024
Merged

Add browser dialer for splithttp #3484

merged 13 commits into from
Jul 11, 2024

Conversation

mmmray
Copy link
Collaborator

@mmmray mmmray commented Jun 29, 2024

this is a bit buggy, the download is interrupted 50% of the time

@yuhan6665
Copy link
Member

Thanks! I will take a look later. Main has been updated to use new logger:

  • errors.LogInfo(ctx, msg...)
  • errors.LogInfoInner(ctx, err, msg...)

@mmmray
Copy link
Collaborator Author

mmmray commented Jun 30, 2024

there is still some kind of promise leak in the dialer page. after directing my main browser (firefox) with a few 100 tabs through this browser dialer and waiting for 10 minutes, the dialer tab (chrome) becomes unresponsive, right click on that page stops working (??) and the tab needs to be killed

setup is like this:

firefox -> xray client -> chrome dialer -> cloudflare splithttp config -> freedom

I couldn't reproduce this issue with iperf yet. Refreshing the dialer page (before it freezes) fixes everything, maybe it should just refresh itself periodically

@yuhan6665
Copy link
Member

Although I don't know much about the browser dialer, I looked over the commits, I think it is good and we can merge and keep improving in main.

@mmmray
Copy link
Collaborator Author

mmmray commented Jul 8, 2024

Last time I checked it, opening and closing GET repeatedly causes the dialer to freeze after 15 minutes to 1 hour. Mux can probably work around this. If somebody can reproduce what I am seeing, it would be good.

And it's also ok to merge it into main, since the refactor is quite big, up to you.

@mmmray
Copy link
Collaborator Author

mmmray commented Jul 8, 2024

After thinking about it, I now agree that it is probably best to improve this further in main.

I have confirmed that enabling mux works around the dialer bugs well enough and makes it usable. I will (try to) improve this situation in the future if somebody cares about it.

Please review.

@mmmray mmmray marked this pull request as ready for review July 8, 2024 22:06
@yuhan6665
Copy link
Member

I will merge later if no other comments..

@RPRX
Copy link
Member

RPRX commented Jul 11, 2024

主要是怕把原有的 WSS Browser Dialer 改炸,不过这功能用起来麻烦些所以用的人不多,毕竟目前 GFW 没封 uTLS,uTLS 更方便

所以虽然我没深入看代码,但我觉得可以先合了,然后等喜欢折腾的用户当小白鼠

@RPRX RPRX merged commit c8f6ba9 into XTLS:main Jul 11, 2024
34 checks passed
@mmmray mmmray deleted the splithttp-dialer branch July 11, 2024 11:53
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants