修复ws X-Forwarded-For 读取 #3546
Merged
修复ws X-Forwarded-For 读取 #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mmmray 顺便检查下 SplitHTTP 和 HTTPUpgrade 读取 X-Forwarded-For |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
How embarassing, thanks for fixing! I can confirm that SplitHTTP and HTTPUpgrade have the correct code. It seems there is a test for this behavior in all transports, but it is missing a proper assertion. Updated it. |
This was referenced Jul 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
似乎在 c8f6ba9 删掉了看起来不必要的远程IP字段改为直接从conn读取 但是这个字段用于传递X-Forwarded-For里的信息 直接读等于无视了这个头里的信息 导致了#3545