Fix# 143 - EPERM error in Windows

[sjmcdowall]

This is just a simple kludge to remove the error when demeteorizing on Windows with an older node version. Seems to work in my testing.

[fiveisprime]

This doesn't exactly do what you want it to... Just replace the comment block
and the unlink call with

Fs.chmodSync(packagePath, '0644');

You'll have to update the tests to reflect this change as well. This is a much
better solution to the file permissions. 😄

[sjmcdowall]

Well -- it does do exactly what I want .. but maybe it's not the cleanest. :) I was trying to minimize the code flow and only for the case where we failed on Windows. Are you saying you'd rather always just do the chmod .. and no unlink is even needed? Well that's cool.

Also, being new to this -- how do I run the tests "locally" before I commit to make sure they pass?

Cheers

[fiveisprime]

Yeah, there's no need to remove the file if the permissions are changed. 👍

Run npm test to run the tests locally. You'll need to replace the unlinkSync
mock in the unit test with a chmodSync mock. That should do it for the tests.

[sjmcdowall]

Thanks -- did exactly that and now everything seems to be working fine.

[fiveisprime]

Just a couple of things, convert your tabs to spaces, change your quotes to
single quotes, and remove the extra space around those calls.

[sjmcdowall]

OK -- but I rather LIKE the spaces around the calls .. IMHO -- easier to read.. but that's me.. :)

I know I should have used Sublime to make the changes and not vi! LOL ..

[fiveisprime]

One more thing, the second call to chmodSync isn't necessary since the file
isn't being overwritten. Also, that call happens after the done callback is
passed off.

[sjmcdowall]

Well that was easy! HA! :)

[fiveisprime]

👍 Thanks for the contribution!

[sjmcdowall]

Thanks for walking me through it -- obviously once you saw the original code you could have had it all done in about 2 minutes and not 3 more commits! :)