-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove split CCL #644
Remove split CCL #644
Conversation
I added the sequential version and unit tests |
I had some misunderstanding about the method, will fix it tomorrow |
I think this PR is ready for review now |
@DongWuTUM The computational time of damping is too long. I ran the same simulation without and with damping, the previous one took 104s and the later one took 199s, nearly a 90% increment. FYI, for test_3d_arch, the computational time on my machine is: The damping computational time of the new method is twice more than that of the old method |
@WeiyiVirtonomy I guess that there is something wrong. |
…amics_restructure
@WeiyiVirtonomy As the master has been updated, the conflicts must be resolved first for the merge. i also noticed that there are some function is base mesh have repeating implementation, please also clean these repeating if there is any. |
Merge conflict is now solved |
The split cell linked list is replaced by a function called
particle_for_split
, where the cells are accessed by a stride of 3 in the indices.TODO:
Add sequential version
Add unit test