cleanup: Add ContainerFileNotices for Ubuntu & MachineConfig #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcrawley-xilinx
approved these changes
Dec 8, 2023
|
"Missing" in the commit message could be more specific by naming the two. |
ivatet-amd
force-pushed
the
reviews/iteterev/cleanup-container-file-notice
branch
from
22c034a to
671168c
Compare
ivatet-amd
changed the title
|
@pcolledg-amd Thanks, I've expanded the commit message. 👍 |
|
Apologies, I didn't mean literally quantity of |
|
I've listed them in the body of the commit message, but your version works for me too. |
There are two new Dockefiles: one to generate SFC MachineConfig, and another is an Onload kernel module builder for the Ubuntu kernels. This patch adds the corresponding ContainerFileNotice even though the latter image is a template.
ivatet-amd
force-pushed
the
reviews/iteterev/cleanup-container-file-notice
branch
from
671168c to
3cb5dd2
Compare
ivatet-amd
changed the title
ivatet-amd
deleted the
reviews/iteterev/cleanup-container-file-notice
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two new Dockefiles: one to generate SFC MachineConfig, and another is an Onload kernel module builder for the Ubuntu kernels. This patch adds the corresponding ContainerFileNotice even though the latter image is a template.
Re on Dockerfiles:
releasetag.