Cleanup: Fix in-cluster-build sample #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found two issues with the existing samples for in-cluster-builds: 1. If the `onload-clusterlocal` didn't exist with the correct RoleBindings, then the KMM operator would fail to check whether the image existed (which prevented a build happening). 2. Incorrect ImageStream specification (we were including an unnecessary `/onload`). Both should be fixed with this patch.
pcolledg-amd
approved these changes
Dec 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two issues with the existing samples for in-cluster-builds:
onload-clusterlocaldidn't exist with the correct RoleBindings, then the KMM operator would fail to check whether the image existed (which prevented a build happening)./onload).Both should be fixed with this patch.
The duplication of
imagestream.yamlisn't ideal, butin-cluster-build-ocpandin-cluster-build-ocp-clusterlocalalready have identical files (patch-onload.yaml) so I don't think it is the end of the world.Testing done
On
master:oc create -k config/samples/onload/overlays/in-cluster-build-ocpcreates and Onload CR, but the KMM fails to create a build pod for the module.With this patch it can create the build pod which runs correctly.