Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cleanup: Static Analysis workflow -- split Go & non-Go #125

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions .github/workflows/static-go.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
# SPDX-License-Identifier: MIT
# (c) Copyright 2023-2024 Advanced Micro Devices, Inc.
name: "Static Analysis - Go"

on:
workflow_dispatch:
inputs:
lint_codebase:
description: Lint all files instead of changed
default: false
required: true
type: boolean
pull_request:
branches: [master]
paths:
- '**.go'
- go.mod
- Makefile
push:
branches: [master]
paths:
- '**.go'
- go.mod
- Makefile
# schedule:
# - cron: '44 2 * * 5'

env:
lint-all: ${{ github.event_name == 'workflow_dispatch' && inputs.lint_codebase }}
permissions:
contents: read
jobs:
# super-linter has issues with go-1.21 & linting of changed go files only
lint-go:
name: Go Linter
runs-on: ubuntu-latest
timeout-minutes: 20
steps:

- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod
cache: false # handled by linter action

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.54 # go 1.21
only-new-issues: ${{ !env.lint-all }}

unit-tests:
name: Unit Tests
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod

- run: make test

analyse:
name: CodeQL
runs-on: ubuntu-latest
needs: [ unit-tests, lint-go ] # cost mitigation
timeout-minutes: 360
permissions:
actions: read
contents: read
security-events: write
strategy:
fail-fast: false
matrix:
language: [ go ]
steps:

- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod

- name: Go - download dependencies
run: go get

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
queries: security-extended,security-and-quality

- name: Go Build on Operator, Device Plugin, and Worker
run: make build device-plugin-build worker-build

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
with:
category: "/language:${{ matrix.language }}"
94 changes: 9 additions & 85 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: MIT
# (c) Copyright 2023 Advanced Micro Devices, Inc.
# (c) Copyright 2023-2024 Advanced Micro Devices, Inc.
name: "Static Analysis"

on:
Expand All @@ -12,22 +12,25 @@ on:
type: boolean
pull_request:
branches: [master]
paths-ignore:
- '**.go'
- go.mod
push:
branches: [master]
# schedule:
# - cron: '44 2 * * 5'
paths-ignore:
- '**.go'
- go.mod

env:
lint-all: ${{ github.event_name == 'workflow_dispatch' && inputs.lint_codebase }}
permissions:
contents: read
jobs:
lint-general:
name: Super Linter
runs-on: ubuntu-latest
timeout-minutes: 20
permissions:
contents: read
packages: read
statuses: write
steps:

Expand All @@ -37,7 +40,7 @@ jobs:
fetch-depth: 0 # super-linter req

- name: Super Linter
uses: docker://ghcr.io/super-linter/super-linter:slim-v5.3.1 # go-1.21
uses: super-linter/super-linter/slim@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# super-linter is designed around linting changed files only,
Expand All @@ -50,82 +53,3 @@ jobs:
ERROR_ON_MISSING_EXEC_BIT: true
LINTER_RULES_PATH: /
YAML_CONFIG_FILE: .yamllint.yml
GO_LINTER_RULES: .golangci.yml

# super-linter has issues with go-1.21 & linting of changed go files only
lint-go:
name: Go Linter
runs-on: ubuntu-latest
timeout-minutes: 20
steps:

- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod
cache: false # handled by linter action

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.54 # go 1.21
only-new-issues: ${{ !env.lint-all }}

unit-tests:
name: Unit Tests
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod

- run: make test

analyse:
name: CodeQL
runs-on: ubuntu-latest
needs: [ unit-tests, lint-go ] # cost mitigation
timeout-minutes: 360
permissions:
actions: read
contents: read
security-events: write
strategy:
fail-fast: false
matrix:
language: [ go ]
steps:

- name: Checkout repository
uses: actions/checkout@v4

- name: Go - setup env
uses: actions/setup-go@v4
with:
go-version-file: go.mod

- name: Go - download dependencies
run: go get

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
queries: security-extended,security-and-quality

- name: Go Build on Operator, Device Plugin, and Worker
run: make build device-plugin-build worker-build

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
with:
category: "/language:${{matrix.language}}"