Fix (proxy): clean-up #1011
Merged
Fix (proxy): clean-up #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
commented
Aug 28, 2024
|
|
||
| class BiasQuantProxyFromInjectorBase(ParameterQuantProxyFromInjector, BiasQuantProxyProtocol, ABC): | ||
|
|
||
| def __init__(self, quant_layer: nn.Module, quant_injector: Injector) -> None: | ||
| super().__init__(quant_layer, quant_injector) | ||
| self._cached_bias = None | ||
| self.cache_inference_quant_bias = False | ||
| self.cache_inference_quant_bias_metadata_only = False | ||
| self.requires_input_scale = self.quant_injector.requires_input_scale |
There was a problem hiding this comment.
The previous solution is not compile-friendly (even though this PR is not about compile).
Happy to restore this to previous state.
Giuseppe5
force-pushed
the
proxy_cleanup
branch
from
1b9d4d7 to
12bf43f
Compare
nickfraser
requested changes
Aug 29, 2024
nickfraser
reviewed
Sep 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.