Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix (nn): QuantConv group calculation #703

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix (nn): QuantConv group calculation #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/brevitas/nn/quant_conv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def inner_forward_impl(self, x: Tensor, quant_weight: Tensor, quant_bias: Option
def max_acc_bit_width(self, input_bit_width, weight_bit_width):
max_uint_input = max_int(bit_width=input_bit_width, signed=False, narrow_range=False)
max_kernel_val = self.weight_quant.max_uint_value(weight_bit_width)
group_size = self.out_channels // self.groups
group_size = self.in_channels // self.groups
max_uint_output = max_uint_input * max_kernel_val * self.kernel_size[0] * group_size
max_output_bit_width = ceil_ste(torch.log2(max_uint_output))
return max_output_bit_width
Expand Down Expand Up @@ -209,7 +209,7 @@ def inner_forward_impl(self, x: Tensor, quant_weight: Tensor, quant_bias: Option
def max_acc_bit_width(self, input_bit_width: Tensor, weight_bit_width: Tensor):
max_uint_input = max_int(bit_width=input_bit_width, signed=False, narrow_range=False)
max_kernel_val = self.weight_quant.max_uint_value(weight_bit_width)
group_size = self.out_channels // self.groups
group_size = self.in_channels // self.groups
kernel_size = self.kernel_size[0] * self.kernel_size[1]
max_uint_output = max_uint_input * max_kernel_val * kernel_size * group_size
max_output_bit_width = ceil_ste(torch.log2(max_uint_output))
Expand Down