[Streamline] Allow AbsorbSignBiasIntoMultiThreshold to absorb any bias #1173
+125
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Keep the name indicating only handling signed-bias but adjust the datatype inference after absorbing the bias to handle signed bias as well as outputs.
…to-multithreshold
Adds more (proably too much) code documentation and more usefule warnings instead of a single hard assertion failure...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Keep the name indicating only handling signed-bias but adjust the datatype inference after absorbing the bias to handle signed bias as well as outputs.
Draft PR for now, related to work on streamlining for more generalized activation function support via multi-thresholds, but this could be of interest in any situation where it is easier to move some bias (not just the exported sign-bias but any scalar
Add) upwards instead of downwards through the graph, e.g., if there is some joiningMulorMatMuloperation blocking the usual flow of streamlining transformation.