Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Xpra launcher doesn't seem to load SSL options(?) #4524

Closed
zusorio opened this issue Mar 5, 2025 · 1 comment
Closed

Xpra launcher doesn't seem to load SSL options(?) #4524

zusorio opened this issue Mar 5, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@zusorio
Copy link

zusorio commented Mar 5, 2025

Describe the bug
I was trying to connect to a wss:// endpoint using the Xpra Launcher and got the error you must specify an 'ssl-cert' file to use ssl sockets. After some digging it turns out this was because the method responsible for creating the ssl socket defaults to server_side=True and wasn't being passed the right options. After modifying get_ssl_wrap_socket_context to force-disable server_side, there's a new error about server_hostname being empty. After also manually setting this to the correct hostname, I'm getting a new error because the custom certificate I'm specifying isn't being respected (both when passing it via the cli or a launcher file).

After digging around in the code for a while, I was able to find the code for parsing these options, but it doesn't seem to be used for the launcher, only commands like xpra attach.

To Reproduce
I think connecting to any wss:// endpoint should be enough to reproduce this, since none of the SSL options are being loaded.

System Information:

  • Client OS: macOS 15.3.1 (24D70)
  • Xpra Client Version: The latest macOS Beta builds
@zusorio zusorio added the bug Something isn't working label Mar 5, 2025
@totaam
Copy link
Collaborator

totaam commented Mar 6, 2025

Xpra Client Version: The latest macOS Beta builds

Do not do this. See https://github.com/Xpra-org/xpra/wiki/Reporting-Bugs : "I have the latest version installed"

Fixed in abe55f7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants