Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: Cleanup Failing Patches #153

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat!: Cleanup Failing Patches #153

merged 2 commits into from
Mar 27, 2024

Conversation

podarok
Copy link

@podarok podarok commented Jan 26, 2024

TODO: Check all respective landed @podarok

Original Issue, this PR is going to fix: REPLACE WITH A LINK TO ISSUE ( publicly available )

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use main branch. We'll tag for release if the bug is critical ASAP or tag for release next bug fix release until the critical issue arrives.

Steps for review

  • Please provide steps for review here.

General checks

Thank you for your contribution!

TODO: Check all respective landed @podarok
@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4577/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4577/install.php

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4577/

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4577/

@podarok
Copy link
Author

podarok commented Jan 26, 2024

- Applying patches for drupal/core
    https://www.drupal.org/files/issues/2022-08-09/hook-block-execute-3292520-14.patch (#3292520 Execute hook_block_view_alter when placing blocks with layout builder)

  - Applying patches for drupal/admin_toolbar
    https://www.drupal.org/files/issues/2023-02-06/3335841-2.patch (Issue #3335841 - Admin toolbar menu z-index increase)

  - Applying patches for drupal/colorapi
    https://www.drupal.org/files/issues/2020-09-16/3171235-2.patch (3171235 - Add Value property)
    https://gist.githubusercontent.com/manachynskyi/a24c7898a0ed051bc077fc94cc2dc2e8/raw/9524fa2d630d2ee0e0e39316156612b33c854182/colorapi_config_patch.patch (Update colorapi configs)

  - Applying patches for drupal/entity_clone
    https://git.drupalcode.org/project/entity_clone/-/merge_requests/42.diff (3050027: Entity clone does not work properly with Layout Builder block)

  - Applying patches for drupal/media_library_form_element
    https://www.drupal.org/files/issues/2023-05-10/check-default-value-not-array-15044301-16.patch (Issue #3341978: TypeError: explode(): Argument #2 ($string) must be of type string, array given in explode().)

  - Applying patches for ynorth-projects/openy_repeat
    https://github.com/ynorth-projects/openy_repeat/compare/9.x-2.x...seattleymca:YGSSLA-396.diff (Fix for openy_repeat so it can be used as a Schedules page filter [https://yusa.atlassian.net/browse/DS-1100](https://yusa.atlassian.net/browse/DS-1100%1B[39m))

  - Applying patches for drupal/ckeditor5_font
    https://www.drupal.org/files/issues/2023-04-21/3350333-5.patch (Issue #3350333: TypeError: array_filter(): Argument #1 ($array) must be of type array.)

  - Applying patches for drupal/video_embed_field
    https://git.drupalcode.org/project/video_embed_field/-/merge_requests/3.diff (Issue #3215817: Presentational attributes such as 'border', 'align', or 'bgcolor' are used. CSS should be used for styling instead.)
    https://www.drupal.org/files/issues/2023-09-12/3311063-35.patch (Add support for Ckeditor 5, see [https://www.drupal.org/project/video_embed_field/issues/3311063#comment-15227318](https://www.drupal.org/project/video_embed_field/issues/3311063#comment-15227318%1B[39m))

  - Applying patches for drupal/plugin
    https://www.drupal.org/files/issues/2020-07-22/2647312-32.patch (2647312 - Use SubFormState in plugin selectors)

  - Applying patches for drupal/entity_browser
    https://www.drupal.org/files/issues/2845037_15.patch (2845037 - Fixed the issue of Call to a member function getConfigDependencyKey() on null on [Widget view], and [SelectionDisplay view])
    https://www.drupal.org/files/issues/2020-10-16/3104901-17.patch (3104901 - Entity Browser used in a entity referenced field of a layout builder custom block is not working)

  - Applying patches for drupal/inline_entity_form
    https://git.drupalcode.org/project/inline_entity_form/-/merge_requests/94.diff (Issue #3403113: fixed save sub-block)
    https://git.drupalcode.org/project/inline_entity_form/-/merge_requests/95.diff (Issue #3398615: Save is broken in modal)

  - Applying patches for drupal/lb_claro
    https://git.drupalcode.org/project/lb_claro/-/merge_requests/6.diff (Issue #3383836: Exclude revert and discard)

no more errors

Copy link
Collaborator

@anpolimus anpolimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the deleting old and outdated patches that are already in code.
We just have to more carefully do regression testing when its planned

@podarok
Copy link
Author

podarok commented Mar 5, 2024

I'll make it after 10.3.2 release @anpolimus

@podarok podarok merged commit 7074d90 into main Mar 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants