Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Update paths for webmanifest and add svg. #167

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

froboy
Copy link

@froboy froboy commented Mar 29, 2024

https://yusa.atlassian.net/browse/DS-1287

Checker failed a couple places. Cleaning those up. I think that’s as good as we’re going to be able to do.

  • the hardcoded paths won’t work for the builds as they’re in subdomains, but they will work in most other sites.
  • browserconfig.xml isn’t detected at the root path, but I’ve added an entry which should get rewritten with the configured path so it’s found.
  • I added an SVG favicon which is now supported as well.

Steps for review

General checks

Thank you for your contribution!

@froboy
Copy link
Author

froboy commented Mar 29, 2024

ok to test

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4674/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4674/install.php

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4674/

@froboy
Copy link
Author

froboy commented Mar 30, 2024

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4675/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4675/install.php

@ciboxbot
Copy link
Collaborator

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4675/

@froboy
Copy link
Author

froboy commented Apr 1, 2024

retest this please

@ciboxbot
Copy link
Collaborator

ciboxbot commented Apr 1, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4679/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4679/install.php

@ciboxbot
Copy link
Collaborator

ciboxbot commented Apr 1, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4679/

@ciboxbot
Copy link
Collaborator

ciboxbot commented Apr 1, 2024

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4680/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4680/install.php

'responsive_favicons.settings',
]);
// Clear all cache to rebuild cached favicon
drupal_flush_all_caches();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to invalidate only needed cache bin without flushing all caches?
upgrade path is heavy (

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@podarok podarok merged commit 5a4e593 into YCloudYUSA:main Apr 1, 2024
@ciboxbot
Copy link
Collaborator

ciboxbot commented Apr 1, 2024

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4680/

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants