Endsection handling #332
Merged
Endsection handling #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
SmileyAG
added a commit
to SmileyAG/BunnymodXT
that referenced
this pull request
Sep 22, 2022
* Perform game-ending tasks on trigger_endsection * Apply autostop for Hazard Course if targetname == 'tr_endchange' * EndSection: stop timer w/o required conditions in bxt_timer_autostop 2 Co-authored-by: SmileyAG <redstyle45@gmail.com> Co-authored-by: SmileyAG <58108407+SmileyAG@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hazard Course ends the game via the trigger_endsection entity, and possibly some other mods or campaigns. This PR just handles this game ending method so that the timer is stopped and LiveSplit stops too, because previously we had to stop both manually when running Hazard Course and it was a bit annoying, specially when you're new to running the thing and don't know what's going on with the timer/splits.
Smiley mentioned that there's some case where sending the player to the menu via trigger_endsection is not meant to end the game, but only one level or something, and then the player goes back to chapter selection or whatever and continues from there. For this reason, it won't automatically end the game on
bxt_timer_autostop 1unless it's Hazard Course. The player will have to setbxt_timer_autostop 2if they actually want the game to end, so they have this workaround and they don't need to wait for someone to hardcode their mod's trigger targetname for it to work out of the box.