-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Custom splits #397
Merged
Merged
Custom splits #397
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bf74d9a
Implement splits
fireblizzard 86020cd
Allow splitting on entities by name or target
fireblizzard c9c44ec
Included splits files to CMakeLists.txt
SmileyAG 561e371
Fix inconsistent mentions to splits
fireblizzard dde0167
Fix inconsistent/unnecessary whitespace
fireblizzard e4ba283
Remove trailing wildcards
fireblizzard 0b1d397
Return earlier when failed to split
fireblizzard 443fe40
Avoid printing splits at the end multiple times
fireblizzard 5cd8071
Fix export for split entities
fireblizzard 85ec8b5
Avoid allocating extra string on splits related loops
fireblizzard 3f838f9
Avoid overcomplicated index calculation
fireblizzard 9fd0e8f
Remove wrong comment
fireblizzard fe3d3c3
Remove repeated code by reusing split name/id getter
fireblizzard b6e03b1
Initialize members in the same order as declared
fireblizzard c9fc749
Remove getters/setters in favor of direct field usage
fireblizzard 6ba9d15
Rename split creation functions
fireblizzard c52c31c
Revert bxt_splits_delete to previous search&erase
fireblizzard dea420b
Limit split that is being created to current map
fireblizzard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this won't actually work if this split has an empty name, it's being deleted by id, and there's another split with an empty name before. Or if there are multiple splits with the same name. Maybe worth retaining the search as is then...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, i have reverted it