Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added cl_viewmodel_disable_idle to disable idle/fidget animations on the viewmodel models #124

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

chinese-soup
Copy link
Contributor

@chinese-soup chinese-soup commented Jun 8, 2021

Hello.

I've seen a lot of people use the edited so-called "HLTV" models where idle and fidget sequences are set to 1 frame and 1 fps, this does the same thing but without replacing the original (or HD) models. This works on all the default weapons, but probably not on custom added 3rd party server side weapons (not models, i.e. weapons that are not in original HL1), though, unless they use *fidget* and *idle* in their sequence labels.

It also doesn't work on any custom weapon models that use different labels for idle / fidget. <- If you think it'd be beneficial if this worked for all custom models including ones that have different labels, I can go ahead and implement it based on indexes of sequences for each gun instead.

EDIT: I've had a discussion with @execut4ble and we figured that "HLTV" means more like "1.6" HLTV behaviour (or HLTV viewmodels by Vryndar etc.), where even equip animation for example isn't there, therefore I've changed the cvar accordingly to just imply "no idle or fidget animations", we've figured that equip is a useful animation since you know when you can actually shoot the gun.

So either just leave the renamed cvar like this to disable idle/fidget (cl_viewmodel_disable_idle) or we could add a feature where the cvar would be cl_viewmodel_hltv (or something else, see below), but it would have levels of

  • 1* = no idle animations, no fidget animations
  • 2* = no equip/holster/draw animations

It could also just be two seperate cvars cl_viewmodel_disable_idle and cl_viewmodel_disable_equip for example (<- this is the current PR implementation). Or again, two in one [11:44 PM] execut4ble: or cl_viewmodel_static (0/1/2) etc. etc.

For completeness:

EDIT 2: I've added the no equip (holster/draw/deploy) cvar cl_viewmodel_disable_equip, like mentioned above, for posterity. Can be later changed to be a single one / removed entirely, etc. like mentioned above

EDIT 3: Behaviour of these two cvars can be see in this video:
https://user-images.githubusercontent.com/5108747/121267183-16642200-c8bc-11eb-9171-36c8945b7c8c.mp4

@chinese-soup chinese-soup changed the title Added cl_viewmodel_hltv to disable idle/fidget animations on the viewmodel models Added cl_viewmodel_disable_idle to disable idle/fidget animations on the viewmodel models Jun 8, 2021
@chinese-soup chinese-soup force-pushed the hltv_models branch 3 times, most recently from e876099 to bf6122f Compare June 8, 2021 22:43
@YaLTeR
Copy link
Owner

YaLTeR commented Jun 9, 2021

I think the current _disable_idle and _disable_equip cvars make the most sense.

Copy link
Owner

@YaLTeR YaLTeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess send this to interested players and if they confirm it works as they want we can merge.

@SmileyAG
Copy link
Contributor

I guess send this to interested players and if they confirm it works as they want we can merge.

I can confirm that works as well on random v_model packs, merge it! 😃

@YaLTeR YaLTeR merged commit d240ab2 into YaLTeR:master Jun 28, 2021
@YaLTeR
Copy link
Owner

YaLTeR commented Jun 28, 2021

Cool, thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants