Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add jumpspeed HUD like in BXT #136

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Conversation

chinese-soup
Copy link
Contributor

@chinese-soup chinese-soup commented Jun 28, 2021

Closes #133

Stolen from BXT, based on hud_speedometer.cpp.

Normal Y pos based on the original BXT (1 "px" above hud_speedometer), for "below cross" I've decided to have it under hud_speedometer for simplicity (i.e. not dynamically moving based on hud_speedometer_below_cross's value)

Not too sure about the static floats and what not in the code, so do tell me, if it somehow doesn't make sense here, but does in BXT.

Video:
https://user-images.githubusercontent.com/5108747/123566130-3900a100-d7bf-11eb-88d1-b09b33f0f514.mp4

Copy link
Owner

@YaLTeR YaLTeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly thrilled about the second _below_cross, but the alternative is essentially to merge jumpspeed into speedometer and I'm not sure that's good either. Or maybe there aren't actually any players who want just one but not the other? Then they can be merged.

cl_dll/hud_jumpspeed.cpp Outdated Show resolved Hide resolved
cl_dll/hud_jumpspeed.cpp Outdated Show resolved Hide resolved
cl_dll/hud_jumpspeed.cpp Outdated Show resolved Hide resolved
cl_dll/hud_jumpspeed.h Show resolved Hide resolved
@chinese-soup
Copy link
Contributor Author

chinese-soup commented Jun 28, 2021

Not particularly thrilled about the second _below_cross, but the alternative is essentially to merge jumpspeed into speedometer and I'm not sure that's good either. Or maybe there aren't actually any players who want just one but not the other? Then they can be merged.

I guess getting rid of the hud_jumpsped_below_cross cvar and syncing the position with hud_speedometer_below_cross could be another option without merging it with hud_speedometer.cpp altogether, wdyt?

@YaLTeR
Copy link
Owner

YaLTeR commented Jun 28, 2021

Yeah but that's also a bit weird if you have just jumpspeed on and want to move it.

@YaLTeR YaLTeR merged commit 2289ed1 into YaLTeR:master Jun 29, 2021
@YaLTeR
Copy link
Owner

YaLTeR commented Jun 29, 2021

Thanks!

SmileyAG added a commit to SmileyAG/BugfixedHL-Rebased that referenced this pull request Aug 2, 2021
SmileyAG added a commit to SmileyAG/BugfixedHL-Rebased that referenced this pull request Aug 2, 2021
SmileyAG added a commit to SmileyAG/BugfixedHL-Rebased that referenced this pull request Aug 3, 2021
tmp64 pushed a commit to tmp64/BugfixedHL-Rebased that referenced this pull request Aug 12, 2021
SmileyAG pushed a commit to SmileyAG/OpenAG that referenced this pull request Dec 14, 2023
* Add jumpspeed HUD like in BXT

* Get rid of static members

* Revert hud_jumpspeed_below_cross removal
SmileyAG pushed a commit to SmileyAG/OpenAG that referenced this pull request Dec 14, 2023
* Add jumpspeed HUD like in BXT

* Get rid of static members

* Revert hud_jumpspeed_below_cross removal
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jumpspeed HUD
2 participants