Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindgen 0.71 and latest rust nightly version.
Bindgen does not right away so there are some changes to bindgen such as
c_uint
toc_int
or*mut T
to*const T
. With that, bxt-rs code can remain unchanged. Bindgen also makes function type to beOption<unsafe extern ...>
instead of the usualunsafe extern ...
. So, for some parts, I add.unwrap()
wherever applicable. There are a lot of changes needed doing after generating bindings so I write all instructions along with the bindgen command inside each binding files.Some files are deleted because the new bindgen conveniently generates bunch of related structs. There are some re-declared structs such as
hull_s
where its members are defined in some files and not defined in some files. Doesn't seem like a problem.I am able to load a TAS and interact with the editor just fine. If anything to worry about, it is the
tas_server_time_fix
because there is a small change to the code that does pointer comparison. Though the changed code is from rust_analyzer suggestion so I guess it is all okay.