Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change the max hostname length to be 60 instead of 63. #2231

Merged
merged 1 commit into from
May 9, 2019
Merged

Change the max hostname length to be 60 instead of 63. #2231

merged 1 commit into from
May 9, 2019

Conversation

ealter
Copy link
Contributor

@ealter ealter commented May 9, 2019

Internal tracking ticket: PAASTA-15442

This will enable us to workaround
github/gh-ost#734

@ealter
Change the max hostname length to be 60 instead of 63.
5cc4e35 
Internal tracking ticket: PAASTA-15442

This will enable us to workaround
github/gh-ost#734
@ghost ghost added the in review label May 9, 2019
EvanKrall
EvanKrall approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@EvanKrall EvanKrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in the future we find something with an even sillier hostname length limit, we should make it possible to override this per service, but for now I think this is totally reasonable.

@EvanKrall EvanKrall merged commit 5cc4e35 into Yelp:master May 9, 2019
@ghost ghost removed the in review label May 9, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@EvanKrall EvanKrall EvanKrall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ealter @EvanKrall