-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
standardize docstrings #30
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 94.31% 94.44% +0.13%
==========================================
Files 11 12 +1
Lines 422 432 +10
==========================================
+ Hits 398 408 +10
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X feels weird to me (thinking more adj_mtx, but also for LISI it would bug out on non-KNN adj mtxes bc there would be uneven number of neighbors), but u do u
import numpy as np | ||
import scipy.sparse as sp | ||
|
||
ArrayLike = Union[np.ndarray, sp.spmatrix, jnp.ndarray] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres a types file for this i thought
You are right we should have one variable name for knn graphs and one for embeddings Maybe we should use |
No description provided.