Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Command "==ping" not working properly #9

Closed
SakuraIsayeki opened this issue Jun 25, 2019 · 2 comments
Closed

Command "==ping" not working properly #9

SakuraIsayeki opened this issue Jun 25, 2019 · 2 comments
Assignees
@SakuraIsayeki
Labels
bug Something isn't working

Comments

@SakuraIsayeki
Copy link
Member

SakuraIsayeki commented Jun 25, 2019 •
edited
Loading

Command ==ping is not working under these scenarios :

  • ==ping [IP Address]
  • ==ping [Valid Hostname]

By implying valid, supplying an invalid Hostname will work (per the prior use of IP Resolver when supplying a Hostname).
@SakuraIsayeki SakuraIsayeki added the bug Something isn't working label Jun 25, 2019
@SakuraIsayeki SakuraIsayeki self-assigned this Jun 25, 2019
@SakuraIsayeki SakuraIsayeki pinned this issue Jun 25, 2019
@SakuraIsayeki SakuraIsayeki unpinned this issue Jun 25, 2019
@SakuraIsayeki
Copy link
Member Author

After research, it seems that this issue is caused by Azure's ban on ICMP packets. The usage of System.Net.NetworkInformation.Ping class implies using ICMP protocol, therefore every ping will be timed out before it even reaches its destination.

Current state of the problem implies a redesign of the PingModule class.

SakuraIsayeki pushed a commit that referenced this issue Jun 28, 2019
Replace ICMP Ping by TCP Ping
f33ceae 
Fixing Issue #9
+ Added Debug Flag on Status Page
@SakuraIsayeki SakuraIsayeki mentioned this issue Jun 28, 2019
Merged
@SakuraIsayeki
Copy link
Member Author

SakuraIsayeki commented Jun 28, 2019 •
edited
Loading

Fixed in Release v0.1.3 (f887566), #11.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@SakuraIsayeki SakuraIsayeki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SakuraIsayeki