Testing - v6

[Salamandar]

Problem

• Description of why you made this PR

Solution

• And how do you fix that problem

PR Status

• Code finished and ready to be reviewed/tested
• The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[ericgaspar]

!testme

[yunohost-bot]

😜

[yunohost-bot]

🪱

[Salamandar]

FYI upgrade still doesn't work for a reason i can't understand

[Gredin67]

my guess is that a proper upgrade requires several partial upgrade through intermediate versions, see https://github.com/sleede/fab-manager/releases
[TODO DEPLOY]

[Gredin67]

!testme
I would say that supporting upgrade from such an outdated version in the yunohost package is not necessary. I'm not sure many people use it because it was outdated for so long.
If people want help to upgrade they can contribute to the upstream app by buying the upgrade from Sleede.

I will try to install testing soon.

[yunohost-bot]

Living in the future, are we?

[yunohost-bot]

🎠

[Gredin67]

Installation is failing if I have an admin password with some special chars, such as " or (

2024-08-21 08:03:00,568: DEBUG - + sudo -u fab-manager PATH=/opt/rbenv/versions/fab-manager/bin:/opt/rbenv/shims:/opt/rbenv/bin:/opt/node_n/n/versions/node/18/bin:/opt/node_n/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin bash -c 'set -a; source '\''/var/www/fab-manager/.env'\''; set +a ; RAILS_ENV=production ADMIN_EMAIL='\''fan_admin@domain2.tld'\'' ADMIN_PASSWORD='\'**********\'' bin/bundle exec rails db:schema:load'
2024-08-21 08:03:00,588: WARNING - bash: -c: line 1: unexpected EOF while looking for matching `"'
2024-08-21 08:03:00,593: WARNING - bash: -c: line 2: syntax error: unexpected end of file

https://paste.yunohost.org/raw/lewacoxezu

[Gredin67]

upgrade requires several partial upgrade through intermediate versions

Indeed here is the info : https://github.com/sleede/fab-manager/blob/master/doc/production_readme.md#update-manually
@Salamandar

[Gredin67]

Maybe we should add --confirmed during first admin creation https://github.com/YunoHost-Apps/fab-manager_ynh/blob/testing/scripts/_common.sh#L83-L85

see e.g. https://github.com/YunoHost-Apps/mastodon_ynh/blob/master/scripts/install#L111C150-L111C161
to avoid this sleede/fab-manager#493

[ericgaspar]

!testme

[yunohost-bot]

📚 🪱

[yunohost-bot]

🚀

[ericgaspar]

!testme

[yunohost-bot]

Living in the past, are we? 🐮👁️

[yunohost-bot]

📖 🪱

[Gredin67]

@ericgaspar @Salamandar could someone test successfull email sending ?
I'm wondering whether last changes could have solved my issue #131