Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(docs): Use automatic links in docs #8348

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Mar 14, 2024

Motivation

The non-hyperlink URLs are causing a CI failure on main.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Wrap the URLs in angled brackets

Related cleanups:

  • Removes a couple newlines in a new proptest, apparently rustfmt is is ignoring that macro again.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Mar 14, 2024
@arya2 arya2 self-assigned this Mar 14, 2024
@arya2 arya2 requested a review from a team as a code owner March 14, 2024 00:56
@arya2 arya2 requested review from oxarbitrage and removed request for a team March 14, 2024 00:56
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 00a3120 into main Mar 14, 2024
135 checks passed
@mergify mergify bot deleted the network-methods-cleanup branch March 14, 2024 11:54
@arya2 arya2 mentioned this pull request Apr 15, 2024
43 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-docs Area: Documentation C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants