Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pk from DLogProof from keygen's Round4 is now verified against VSS. #136

Merged
merged 1 commit into from
Sep 5, 2021
Merged

pk from DLogProof from keygen's Round4 is now verified against VSS. #136

merged 1 commit into from
Sep 5, 2021

Conversation

DmytroTym
Copy link
Contributor

In party_i.rs verify_dlog_proofs method changed so it could also check if pk from the proofs are consistent with VSS. Keygen's rounds.rs changed accordingly.

@elichai
Copy link
Contributor

elichai commented Sep 3, 2021

Thanks for opening the PR!

The CI seems to currently fail for unrelated reasons (rust-lang/rust#88582, rust-num/num-bigint#218), we should probably lock a specific rustc version using a rustup-toolchain file and then bump it manually when needed (and look into working towards stable rust)

@elichai
Copy link
Contributor

elichai commented Sep 3, 2021

Code review ACK 292b4da
I actually needed the same in some other projects, maybe we should add a VerifiableSS that cotains DLog proofs with the commitments. (although mine actually needs Pedersen/Elgamal Commitments+proofs so it might still not fit)

@DmytroTym
Copy link
Contributor Author

DmytroTym commented Sep 4, 2021

Sorry, I'm not sure I understood you correctly. Do you want to change curv's VerifiableSS struct to contain DLog proof, or just add a new struct with a vector of VerifiableSS and a DLog proof to multi-party-ecdsa or curv?

@DmytroTym DmytroTym closed this Sep 4, 2021
@DmytroTym DmytroTym reopened this Sep 4, 2021
@DmytroTym
Copy link
Contributor Author

About the failed build - the issue seems to have been solved here: rust-num/num-bigint#220, I ran the build again, it should succeed now.

@omershlo omershlo merged commit 707ce75 into ZenGo-X:master Sep 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants