Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ZEUS-2610: Channels: restore sort by Close Height #2612

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Dec 9, 2024

Description

Relates to issue: ZEUS-2610

Regression from #2561

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added Bug Something isn't working Channels Regression labels Dec 9, 2024
@kaloudis kaloudis added this to the v0.9.4 milestone Dec 9, 2024
@kaloudis kaloudis linked an issue Dec 9, 2024 that may be closed by this pull request
@kaloudis kaloudis merged commit 71596d3 into ZeusLN:master Dec 11, 2024
4 checks passed
@kaloudis kaloudis deleted the zeus-2610 branch December 11, 2024 01:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working Channels Regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channels: restore sort by Close Height
1 participant