Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use index for keyExtractor in nodes DragList #2647

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

myxmaster
Copy link
Contributor

@myxmaster myxmaster commented Dec 17, 2024

Description

Rare edge case, but previously, nodes with identical configurations had the same id, leading to
ERROR Warning: Encountered two children with the same key (and whatever issues in the future).

Now also using index for keyExtractor in nodes DragList.
Since that broke drag functionality, updated DragList to 3.8.0 -> now working fine.
Dragging also tested in currency converter with new DragList version -> working fine as well.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@myxmaster myxmaster changed the title Use UUID for nodes Use index for keyExtractor in nodes DragList Dec 19, 2024
@myxmaster myxmaster marked this pull request as draft December 19, 2024 13:13
@myxmaster myxmaster marked this pull request as ready for review December 19, 2024 14:16
@kaloudis kaloudis merged commit b7cc030 into ZeusLN:master Dec 19, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants