Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ZEUS-2663: LND: update BumpFee params and UI #2664

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Dec 22, 2024

Description

Relates to issue: ZEUS-2663

This PR makes some updates to the Speed up transaction view and LND BumpFee calls, accompanying some changes introduced in LND v0.18.3-beta.

  • force param has been deprecated and replaced with immediate
  • New budget behavior means only 50% of the selected output is used for the fee by default. This has become problematic for users trying to bump a force close channel as they have to use the 330 sat anchor output to bump the TX, resulting in a tiny budget. The newly added, optional, budget field has been added to the view in response.

Other changes:

  • In-house Text component now leveraged on the view
  • Explainers added for immediate and budget fields
  • OnchainFeeInput component added to BumpFee view
  • Speed up channel close + Speed up force channel close actions added to Channel view
  • BumpForceCloseFee endpoint leveraged for FC channels

simulator_screenshot_23915F1C-2F85-493A-A2C9-DBBECF7220D8

simulator_screenshot_5C1B0E3A-D2EC-4A62-8D1B-119F3551ED76

simulator_screenshot_6BC8AF8F-B517-47A8-B0CB-9C74AF327BA1

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added LND Issues specific to LND nodes Fees labels Dec 22, 2024
@kaloudis kaloudis added this to the v0.9.4 milestone Dec 22, 2024
@kaloudis kaloudis linked an issue Dec 22, 2024 that may be closed by this pull request
@kaloudis kaloudis marked this pull request as draft December 22, 2024 16:32
@kaloudis kaloudis force-pushed the zeus-2663 branch 2 times, most recently from a6345af to caa9d2e Compare December 22, 2024 16:55
@kaloudis kaloudis marked this pull request as ready for review December 22, 2024 18:34
@kaloudis kaloudis merged commit e56a654 into ZeusLN:master Dec 23, 2024
4 checks passed
@kaloudis kaloudis deleted the zeus-2663 branch December 23, 2024 02:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Fees LND Issues specific to LND nodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bumpforceclose on lnd embedded node not working
1 participant