Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve biometrics setup flow: Use nav param instead of "pendingBiometricsEnable" state #2711

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

myxmaster
Copy link
Contributor

Description

This fixes #2709 by using forBiometrics navigation parameter when navigating to SetPin or SetPassword instead of state pendingBiometricsEnable.
-> Now whenever user cancels setting up pin or password, the biometric switch will not be enabled, when coming back to Security screen.

Additionally:

  • SetPassword:saveSettings(): removed obsolete nav param refresh
    -> Security.tsx is refreshing settings via checkSettings() in componentDidMount() anyway
  • refactored Security.tsx:handleBiometricsSwitchChange()
    -> removed redundant code in if (isVerified) case

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

…olete nav param "refresh" in SetPassword.tsx:saveSettings(), refactoring
@kaloudis kaloudis requested a review from shubhamkmr04 January 18, 2025 04:07
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 42f69a4 into ZeusLN:master Jan 22, 2025
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge case: Biometric authentification required although unnecessary
3 participants