-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open Channel/Send on-chain: use AmountInput to display fundMax #2769
Conversation
e61170f
to
da42480
Compare
Why do we have to change the unit to sats when it's toggled? |
I think it would be misleading if we had a fiat amount in the amount input, even when it is correctly calculated and the sat amount below in small. |
da42480
to
726c5ba
Compare
(rebased) |
Can we remove Open Channel from title? since its also being changed for onchain txs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
@myxmaster needs a rebase |
beb366a
to
ade5f5f
Compare
Description
This displays the local amount in AmountInput if
Use all possible funds
is enabled, making it consistent/less flickering to normal view.I added
forceUnit
prop to AmountInput to force it to sats mode, which is obviously needed whenUse all possible funds
is used.When you disable it again, values get reset properly.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: