Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ZEUS-1899: ZEUS Pay: add ability to delete address #2840

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Feb 15, 2025

Description

Relates to issue: ZEUS-1899

1 2
simulator_screenshot_952BB7D8-8E72-42B1-9CF8-084394580AAF simulator_screenshot_76EA3B94-3258-4AD6-9718-A5E9E29D6EF1

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.10.0 milestone Feb 15, 2025
@kaloudis kaloudis linked an issue Feb 15, 2025 that may be closed by this pull request
@kaloudis kaloudis force-pushed the delete-lightning-address branch from ebd65bb to 0e65b01 Compare February 15, 2025 01:14
@kaloudis kaloudis changed the title ZEUS-1899: ZEUS Pay: add ability to delete account ZEUS-1899: ZEUS Pay: add ability to delete address Feb 15, 2025
@kaloudis kaloudis marked this pull request as ready for review February 15, 2025 01:25
@kaloudis kaloudis merged commit 97c2ba5 into ZeusLN:master Feb 16, 2025
4 checks passed
@kaloudis kaloudis deleted the delete-lightning-address branch February 16, 2025 22:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZEUS Pay: add ability to delete account
1 participant