Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LNDHub: Tor support (Umbrel) #457

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented May 9, 2021

Description

Relates to issue: ZEUS-452

BlueWallet QR code from Umbrel was incompatible with Zeus. Furthermore, connecting to an LNDHub instance over Tor wasn't possible unless you already had an existing account.

This PR also makes sure people connecting to .onion hosts can untoggle the Enable Tor button so they can continue to use Orbot if they so please.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Other

Checklist

  • I’ve run npm run tsc and make sure my code didn’t produce errors
  • I’ve run npm run prettier and formatted my code correctly

Testing

If you added new functionality or fixed a bug, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND
  • c-lightning-REST
  • spark
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run npm install after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and package-lock.json have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis
Copy link
Contributor Author

Tested and ready to go for the next release

Copy link

@AaronDewes AaronDewes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for adding this.

@ZeusLN ZeusLN merged commit 43e7547 into ZeusLN:master Jun 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants