c-lightning-REST: OpenChannel: make feerate options clear #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: ZEUS-460
Fee options when opening channel for c-lightning-REST are
urgent
,normal
, andslow
. We must make this clear to the user. Future iterations will use a GUI component, such as radio buttons.https://github.com/Ride-The-Lightning/c-lightning-REST/blob/master/docs/channelmgmt.md
This pull request is categorized as a:
Checklist
npm run tsc
and make sure my code didn’t produce errorsnpm run prettier
and formatted my code correctlyTesting
If you added new functionality or fixed a bug, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
npm install
after this PR is merged inpackage.json
andpackage-lock.json
have been properly updatedOther: