Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove erc165 calls from vaults #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

cfcfs
Copy link
Contributor

@cfcfs cfcfs commented Apr 16, 2024

Purpose of this PR 🎯

  • Feature;
  • Bugfix;
  • Tests;
  • Refactoring;
  • Build or CI/CD;
  • Documentation;
  • Code Styling;
  • Other. Please describe:

Changes 📝

Test Coverage 🧻

Does this PR introduce a breaking change? ⚠️

  • No
  • Yes

Related issues 📎

Reviewers 🦺

@cfcfs cfcfs requested a review from DioPires as a code owner April 16, 2024 08:39
@cfcfs cfcfs force-pushed the feat/remove-vault-erc165-calls branch from 912dcb0 to 819cc5c Compare April 16, 2024 08:42
Copy link

github-actions bot commented Apr 16, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
contracts
   CollateralVaultCoreV2.vy60788%60, 71, 76, 82, 158–161
   CollateralVaultOTC.vy1521888%172–175, 243, 248–251, 257, 367, 438–469
   CollateralVaultPeripheral.vy1366751%115–119, 126, 131, 136, 151–162, 167–177, 274–292, 312–382
   CryptoPunksVaultCore.vy701381%69, 74, 80–86, 92–93, 179–182
   LendingPoolCore.vy1682983%112, 118, 124, 130, 136, 142, 157–174, 181–193
   LendingPoolERC20OTC.vy2575081%181–182, 199, 250, 274, 279, 294–320, 342, 345, 358, 363, 369, 375, 381, 387, 393, 399, 405, 411, 417, 429, 500–509, 617, 639, 645, 651, 695–701
   LendingPoolEthOTC.vy2384382%197–198, 279, 310, 334, 339, 345, 351, 357, 363, 369, 375, 381, 387, 393, 405, 482–491, 591, 650–662, 695–723
   LendingPoolLock.vy531081%82–92
   LiquidationsCore.vy95991%94, 99, 104, 109, 114, 119, 124, 129, 134
   LiquidationsOTC.vy25519225%224–329, 338, 344, 350, 355, 360, 365, 370, 375, 380, 385, 470–536, 542–664
   LiquidationsPeripheral.vy50537526%318–466, 473, 478, 667–676, 681–690, 695–704, 709–717, 722–730, 749–803, 809–888, 894–1114
   LoansCore.vy2106470%103, 111–145, 154, 225, 231, 239, 247, 255, 269–271, 279, 287, 295, 303, 311, 319, 327, 373, 379, 384–387, 392–395, 400–402, 435, 490–518
   LoansOTC.vy3815486%316–320, 328, 380–388, 484, 523, 528, 540, 546, 552, 570, 576, 594–596, 646–656, 743, 755, 772, 861, 895–898, 909, 920–921, 974–996
TOTAL258093164% 

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant