Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug report] Typos in options #82

Closed
2 tasks done
Mister-Hope opened this issue Nov 30, 2022 · 3 comments
Closed
2 tasks done

[Bug report] Typos in options #82

Mister-Hope opened this issue Nov 30, 2022 · 3 comments
Assignees
Labels
bug Something isn't working next version Plan for next version

Comments

@Mister-Hope
Copy link

Mister-Hope commented Nov 30, 2022

βœ… Checklist

  • I am using the latest version
  • I have searched FAQ

πŸ“„ System Info

Not related

πŸ”Ž Description

I am not sure if you realize there are mispelling in your options.

allowCustomIssuePrefixs and allowEmptyIssuePrefixs confuse native english speakers.

The options should be allowCustomIssuePrefix and allowEmptyIssuePrefix, which do not need to be plural.

If you DO PREFER plural, prefix should be prefixes.

πŸ”— Reproduction link / repo:

No response

@Mister-Hope Mister-Hope added the bug Something isn't working label Nov 30, 2022
@Mister-Hope
Copy link
Author

If you do not want v2 for this change, mark the original one as deprecated and support the correct spelling, thanks.

@Zhengqbbb Zhengqbbb added the next version Plan for next version label Nov 30, 2022
@Zhengqbbb
Copy link
Owner

Zhengqbbb commented Nov 30, 2022

ref: #36

I will fix the option typos in v1.4.0.
Thx u report and great suggest.

Zhengqbbb added a commit that referenced this issue Dec 3, 2022
BREAKING CHANGE: Main fix `issuePrefixs` typo field
Current version has been already processed for normal compatibility
But I also hope that you can modify this message as soon as possible
```diff
message: {
-    footerPrefixsSelect
+    footerPrefixesSelect
-    customFooterPrefixs
+    customFooterPrefix
}
- issuePrefixs
+ issuePrefixes
- customIssuePrefixsAlign
+ customIssuePrefixAlign
- emptyIssuePrefixsAlias
+ emptyIssuePrefixAlias
- customIssuePrefixsAlias
+ customIssuePrefixAlias
- allowCustomIssuePrefixs
+ allowCustomIssuePrefix
- allowEmptyIssuePrefixs
+ allowEmptyIssuePrefix

```

link #82
Zhengqbbb added a commit that referenced this issue Dec 3, 2022
link #82

Co-authored-by: Zhengqbbb <1074059947@qq.com>
Zhengqbbb added a commit that referenced this issue Dec 4, 2022
BREAKING CHANGE: Main fix `issuePrefixs` typo field
Current version has been already processed for **normal compatibility**
But I also hope that you can modify this message as soon as possible

```diff
{
  message: {
-   footerPrefixsSelect
+   footerPrefixesSelect

-   customFooterPrefixs
+   customFooterPrefix
 }

-   issuePrefixs
+   issuePrefixes

-   customIssuePrefixsAlign
+   customIssuePrefixAlign

-   emptyIssuePrefixsAlias
+   emptyIssuePrefixAlias

-   customIssuePrefixsAlias
+   customIssuePrefixAlias

-   allowCustomIssuePrefixs
+   allowCustomIssuePrefix

-   allowEmptyIssuePrefixs
+   allowEmptyIssuePrefix
}
```

Co-authored-by: Chris < chrisbbreuer@users.noreply.github.com>
@Zhengqbbb
Copy link
Owner

The latest version 🌟(v1.4.0)🌟 should be resolve this issue request , please have a try. πŸ’ͺ
πŸ‘€ Let me know if there are still any issues. Thanks for you suggestion! πŸŽ‰

  • cz-git,czg: main fix issuePrefixs typo field
    • Current version has been already processed for normal compatibility
{
  message: {
-   footerPrefixsSelect
+   footerPrefixesSelect

-   customFooterPrefixs
+   customFooterPrefix
 }

-   issuePrefixs
+   issuePrefixes

-   customIssuePrefixsAlign
+   customIssuePrefixAlign

-   emptyIssuePrefixsAlias
+   emptyIssuePrefixAlias

-   customIssuePrefixsAlias
+   customIssuePrefixAlias

-   allowCustomIssuePrefixs
+   allowCustomIssuePrefix

-   allowEmptyIssuePrefixs
+   allowEmptyIssuePrefix
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working next version Plan for next version
Projects
None yet
Development

No branches or pull requests

2 participants