-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? # to your account
[Bug report] Typos in options #82
Labels
Comments
If you do not want v2 for this change, mark the original one as deprecated and support the correct spelling, thanks. |
ref: #36 I will fix the option typos in v1.4.0. |
Zhengqbbb
added a commit
that referenced
this issue
Dec 3, 2022
BREAKING CHANGE: Main fix `issuePrefixs` typo field Current version has been already processed for normal compatibility But I also hope that you can modify this message as soon as possible ```diff message: { - footerPrefixsSelect + footerPrefixesSelect - customFooterPrefixs + customFooterPrefix } - issuePrefixs + issuePrefixes - customIssuePrefixsAlign + customIssuePrefixAlign - emptyIssuePrefixsAlias + emptyIssuePrefixAlias - customIssuePrefixsAlias + customIssuePrefixAlias - allowCustomIssuePrefixs + allowCustomIssuePrefix - allowEmptyIssuePrefixs + allowEmptyIssuePrefix ``` link #82
Zhengqbbb
added a commit
that referenced
this issue
Dec 3, 2022
link #82 Co-authored-by: Zhengqbbb <1074059947@qq.com>
7 tasks
Zhengqbbb
added a commit
that referenced
this issue
Dec 4, 2022
BREAKING CHANGE: Main fix `issuePrefixs` typo field Current version has been already processed for **normal compatibility** But I also hope that you can modify this message as soon as possible ```diff { message: { - footerPrefixsSelect + footerPrefixesSelect - customFooterPrefixs + customFooterPrefix } - issuePrefixs + issuePrefixes - customIssuePrefixsAlign + customIssuePrefixAlign - emptyIssuePrefixsAlias + emptyIssuePrefixAlias - customIssuePrefixsAlias + customIssuePrefixAlias - allowCustomIssuePrefixs + allowCustomIssuePrefix - allowEmptyIssuePrefixs + allowEmptyIssuePrefix } ``` Co-authored-by: Chris < chrisbbreuer@users.noreply.github.com>
The latest version π(v1.4.0)π should be resolve this issue request , please have a try. πͺ
{
message: {
- footerPrefixsSelect
+ footerPrefixesSelect
- customFooterPrefixs
+ customFooterPrefix
}
- issuePrefixs
+ issuePrefixes
- customIssuePrefixsAlign
+ customIssuePrefixAlign
- emptyIssuePrefixsAlias
+ emptyIssuePrefixAlias
- customIssuePrefixsAlias
+ customIssuePrefixAlias
- allowCustomIssuePrefixs
+ allowCustomIssuePrefix
- allowEmptyIssuePrefixs
+ allowEmptyIssuePrefix
} |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
β Checklist
π System Info
π Description
I am not sure if you realize there are mispelling in your options.
allowCustomIssuePrefixs
andallowEmptyIssuePrefixs
confuse native english speakers.The options should be
allowCustomIssuePrefix
andallowEmptyIssuePrefix
, which do not need to be plural.If you DO PREFER plural, prefix should be
prefixes
.π Reproduction link / repo:
No response
The text was updated successfully, but these errors were encountered: