Add support for SVD dimIndex parsing #508
Open
+4,086
−18,444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peripheral and field tests with DimElementGroup failing now Removed one invalid test with register DimElementGroup
Update existing tests to pass
- added - formatting changes - removed debug sqlite db generation
Grazfather
reviewed
Apr 30, 2025
mattnite
approved these changes
May 1, 2025
There was a problem hiding this comment.
Looks good to me, just get the fixes that @Grazfather has suggested in. It looks like this changes the generated code for esp which will need updating, when I have time I could try to add that to the PR for you tomorrow.
For the stm32 CI failure all you need to do is run zig build -Dgenerate in the port/stmicro/stm32 directory and commit the changes.
Fixed typo in the error name. Simplified dim null check
|
@mattnite The changes do not look good for stm32 now, for example SQR1 is definitely different now. What to do about that specifically? I added the commit here but I believe the stm32 builds will be broken now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DimElementGroup support for peripheral, register and field types (without
dimName)New features:
%sparsing) for DimElementGroupregisterandfieldtypes. register dim description field dim description%scan be anywhere in string,dimIndexmust be defined.[%s]parsing) forDimElementgroupperipheralandregisterperipheral dim description[%s]must be at the end of the stringChanged implementation:
DimElementGrouparray type.elements.dim_increment * 8) != sizeremoved. This is not always true, specifically for list types.Note: This heavily breaks esp examples, rasperrypi seems to still compile.
Partially solves #220
Still to implement:
dimName,displayNamedimIndex