Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logged out of app after auto update #13

Open
aaomidi opened this issue Aug 27, 2017 · 6 comments
Open

Logged out of app after auto update #13

aaomidi opened this issue Aug 27, 2017 · 6 comments
Assignees

Comments

@aaomidi
Copy link
Member

aaomidi commented Aug 27, 2017

The program silently logs out and does NOT notify the user.

@mkotb
Copy link
Member

mkotb commented Aug 27, 2017 via email

@aaomidi
Copy link
Member Author

aaomidi commented Aug 27, 2017

I don't like the "solution" of making them login. We need to exhaustively search for alternative methods of doing this before we end up doing that.

@devmattrick
Copy link
Member

As I mentioned before, a fix for this would only mean you don't "login" but
you still have to open a tab for the firebase service worker to register

@mkotb are you certain of that? From my understanding, once a service worker is registered, it is register permanently until removed manually. I'm not sure how that works with extensions, but that's the way it works in websites and how it is defined in the spec.

@aaomidi
Copy link
Member Author

aaomidi commented Aug 27, 2017

Service Worker termination by a timeout timer was canceled because DevTools is attached.

I saw this while looking at the logs. Are we killing the service workers manually?

@mkotb
Copy link
Member

mkotb commented Aug 28, 2017

@aaomidi We aren't killing them manually. This is simply Chrome notifying you that since DevTools is open (you're inspecting it), it would've usually killed the service worker.

@devmattrick To clarify, I can register the service worker from the background script perfectly fine. But Chrome aggressively attempts to kill idle service workers and restart them (performance and battery purposes). As a result, their states are not persistent and writing them as such ends up creating a buggy service worker. You can find more info here.

The problem at hand here isn't that I can't register the service worker, however connecting to firebase messaging is a problem. I will do some testing and report back on my findings.

@mkotb
Copy link
Member

mkotb commented Aug 28, 2017

Okay, after some testing and finicking with firebase, I have seemed to get it to work and register properly on my machine. I can't guarantee that it will work consistently and would recommend for other people to test the functionality for them. Pushing changes shortly

mkotb added a commit that referenced this issue Aug 28, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants