-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove Gulp in Favor of NPM CLI #1141
base: main
Are you sure you want to change the base?
Conversation
a8f5633
to
86c85c0
Compare
# Conflicts: # gulpfile.js # package-lock.json
putting this work on hold until #989 is addressed at the eleventy is in a better place with incremental build |
Hi @esjay do you have any further interest in working on this? I was looking into upgrading to 11ty v2 first before seeing if we could merge this, but I think due to the nature of how entwined these changes are, I think we need to do both of these changes at the same time. Let us know if you would still be interested in tackling this. It should be a smooth upgrade to v2, the Eleventy Upgrade help plugin (https://github.com/11ty/eleventy-upgrade-help) shows no errors that we need to deal with. |
Upgraded all the dependencies using the great base that Wayne has given us, and now the build does actually run well with Eleventy's incremental watching. I need to compare the site side by side and make sure everything still works, and double check that all the options to our new dependencies are valid/not deprecated. I also need to test whether or not the site builds in Windows (outside of WSL), as this an issue reported by previous contributors. |
(As always, apologies for coming back to this so late.)
I'm wondering what you all feel the best path forwards is. Personally, I do like the idea of keeping it lean with Open to thoughts and suggestions. |
In this PR, per Issue #989, we remove all traces of Gulp in favor of all NPM scripts for both development and build phases. We leverage new CLI-compliant NPM packages where necessary to provide cross-platform compatibility for non-unix-shell environments.