Increase endpoint descriptor's lifetime #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the lifetime of the endpoint descriptor was shorter than the lifetime of the config descriptor, since it was tied to the InterfaceDescriptor object. This commit amends the endpoint_descriptors signature so that an EndpointDescriptor has the same lifetime as the overarching ConfigDescriptor. From my understanding, all state derived from a ConfigDescriptor has a lifetime associated to that ConfigDescriptor. So, it's safe for the EndpointDescriptor to adopt the ConfigDescriptor's lifetime through the InterfaceDescriptor. The new test shows us that the lifetimes are now all equal. This test wouldn't compile without the signature change.
|
LGTM. Thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, all state derived from a
ConfigDescriptorhas a lifetime associated to thatConfigDescriptor. So, it's safe for theEndpointDescriptorto adopt theConfigDescriptor's lifetime through theInterfaceDescriptor.The new test shows us that the lifetimes are now all equal. This test wouldn't compile without the signature change.