Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

horizontal scroll viewable area is too large in file type view #792

Closed
xandark opened this issue Apr 14, 2024 · 3 comments
Closed

horizontal scroll viewable area is too large in file type view #792

xandark opened this issue Apr 14, 2024 · 3 comments
Labels
Archived Unlikely to ever get attention bug DeskTop DeskTop bugs or feature requests

Comments

@xandark
Copy link

xandark commented Apr 14, 2024

The horizontal scrollbar in the file Type view only goes away if the window is resized to show a lot of whitespace padding to the right of the date/time.

In the first screen shot, the horizontal scrollbar is present even when it shouldn't be:

Screenshot 2024-04-13 (22:14:59)

But resize the window just one more pixel wider and it disappears:

Screenshot 2024-04-13 (22:15:11)

This tells me that the horizontal scroll viewable area is too large.

@xandark xandark added bug DeskTop DeskTop bugs or feature requests labels Apr 14, 2024
@inexorabletash
Copy link
Collaborator

The sizing is based on the maximum possible date string length rather computing the actual width. So if you had files from September it would look correct.

I'll take a look to see how hard it would be to make it precise, but it's probably not worth the effort.

@inexorabletash
Copy link
Collaborator

Ah but if it calculates correctly when you resize then there's just a missing call somewhere...

inexorabletash added a commit that referenced this issue Apr 14, 2024
Investigating #792 turned up a glitch in computing the bounding box
for list views. Rather than calculating the actual width of all lines,
a fixed width is used to ensure long dates fit. But this was applied
(1) after the bounding box was inflated and (2) by assigning to a
right edge rather than as a width.

This ensures that when a window is opened in list view (which happens
if the parent window is a list view) then the new window's horizontal
scrollbars will be inactive.
@inexorabletash
Copy link
Collaborator

Okay... I was right, the list view size is fixed - rather than calculating the actual date widths a fixed value is used. There was a glitch where the calculation wasn't quite right.

That said, this does mean that short dates (e.g. "April 1, 2024 at 1:11 PM") leave a lot of space to the right. It looks better with longer dates (e.g. "September 30, 2024 at 2:34 PM")

MacOS System 6 and prior doesn't enable the horizontal scrollbar for list views! System 7 seems to have a fixed width as well. Given that... I'm going to close this out but if someone wants to take a stab at really fixing and it's not too much code or performance hit, I can advise.

@inexorabletash inexorabletash closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
@inexorabletash inexorabletash added the Archived Unlikely to ever get attention label Apr 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Archived Unlikely to ever get attention bug DeskTop DeskTop bugs or feature requests
Projects
None yet
Development

No branches or pull requests

2 participants