Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: update README #19

Merged
merged 1 commit into from
Apr 18, 2022
Merged

docs: update README #19

merged 1 commit into from
Apr 18, 2022

Conversation

jeivardan
Copy link
Collaborator

Added my name to README

@jeivardan jeivardan added the documentation Improvements or additions to documentation label Apr 18, 2022
@jeivardan jeivardan self-assigned this Apr 18, 2022
@niteshkumar2000
Copy link
Collaborator

niteshkumar2000 commented Apr 18, 2022

@jeivardan

/github/workspace/README.md:79:28 MD034/no-bare-urls Bare URL used [Context: "https://jeivardan.tech"]

From logs

README.md Outdated
@@ -76,6 +76,7 @@ flutter build ios --release --no-codesign

- [Aakash Hemadri](https://portal.aakashhemadri.com)
- [Niteshkumar S](https://niteshkumar2000.github.io/portfolio)
- [Jeivardan Venkatesulu] (https://jeivardan.tech)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the space between [] & (url)
It'll pass the linter checks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator Author

@jeivardan jeivardan Apr 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually having these checks is helping a lot

@aakashhemadri
Copy link
Owner

aakashhemadri commented Apr 18, 2022

Never force push @jeivardan
We will always do squash commits.
Neither will it rerun the checks :) Seems like it does

@aakashhemadri
Copy link
Owner

You'll have to re-request review from me, for me to accept review

@jeivardan jeivardan reopened this Apr 18, 2022
@jeivardan jeivardan requested a review from aakashhemadri April 18, 2022 14:09
@jeivardan
Copy link
Collaborator Author

Never force push @jeivardan
We will always do squash commits.
Neither will it rerun the checks :) Seems like it does

okay will not do in the future

@aakashhemadri aakashhemadri merged commit 41dcdcf into master Apr 18, 2022
@aakashhemadri aakashhemadri added this to the Research & Planning milestone Apr 18, 2022
@aakashhemadri aakashhemadri deleted the docs-jeivardan branch April 19, 2022 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants