Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add default value for $numberOfBacktraces in SettledResult::throw #149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Clients/CloudWatchLogsClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@

use Aws\CloudWatchLogs\CloudWatchLogsClient as BaseClient;

class CloudWatchLogsClient extends BaseClient
{
}
class CloudWatchLogsClient extends BaseClient {}
4 changes: 1 addition & 3 deletions src/Clients/S3Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@

use Aws\S3\S3Client as BaseClient;

class S3Client extends BaseClient
{
}
class S3Client extends BaseClient {}
4 changes: 1 addition & 3 deletions src/Exceptions/ConfigurationException.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@

namespace Hammerstone\Sidecar\Exceptions;

class ConfigurationException extends SidecarException
{
}
class ConfigurationException extends SidecarException {}
4 changes: 1 addition & 3 deletions src/Exceptions/LambdaExecutionException.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@

namespace Hammerstone\Sidecar\Exceptions;

class LambdaExecutionException extends SidecarException
{
}
class LambdaExecutionException extends SidecarException {}
4 changes: 1 addition & 3 deletions src/Exceptions/SidecarException.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,4 @@

use Exception;

class SidecarException extends Exception
{
}
class SidecarException extends Exception {}
2 changes: 1 addition & 1 deletion src/Results/SettledResult.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function toResponse($request)
*
* @throws Exception
*/
public function throw(?int $numberOfBacktraces)
public function throw(?int $numberOfBacktraces = null)
{
if (!$this->isError()) {
return $this;
Expand Down
Loading