-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
⬆️ v1.2.7 #6
⬆️ v1.2.7 #6
Conversation
PR for the [issue 4](#4)
Adding workflow tests and fix installation in documentation
Update README.md with deep dependencies workaround
@wellwelwel @emilorol if you folks think, it's good to go, we can ship it |
@aashutoshrathi, I have some small suggestions:
Forward, we can remove completely the |
Should we do this in this version? |
Since after this PR the tests will be enabled, I think this should come next. |
Makes sense to me. |
@aashutoshrathi, I will give my point about that. For CI and general tasks (chore), I never release a new version. In this PR, the changes in documentation are relevant:
About your changes for bower, in case you use it, it's okay. But, since (for some reason), the |
One possibility would be to merge this PR without releasing it. |
I think let's not bump the version and merge this PR |
Also, I don't think it requires, publishing, right? |
Since your concern is to release without significant changes, I suggest waiting until you have enough changes together that you feel safe to release it 🙋🏻♂️
|
Merging but no bumping version yet. |
No description provided.