fix: move linear calculation from v1 to common #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sakulstra I just checked out your branch and the test I introduced in #114 is green :) Looks good to me! Thanks |
kyzia551
approved these changes
Mar 10, 2021
sendra
approved these changes
Mar 10, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes the liquidity part of #114, @alexandre-abrioux please have a look if this makes sense to you.
@kyzia551, please have a look as well - should we flag this breaking / should i add reexports to
v1.to make this non breaking?If yes i should probably also drop that commit
803808aa5baf69dab97367ef7795d998b0f7c15cas i flattened the properties to be less based on thegraph types/ easier to use without thegraph.