Fix read_asdf on rv data
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In changing how
unpack_rvinthandled shapes in 2597bbd, we neglected to change how it handled the case where theposoutarray was being provided by the user. That's mostly because it uses the tricky idiomarr.shape = -1, which is a way of doingnp.reshape(..., copy=False)(only available since NumPy 2.1). The fix is just to doarr.shape = (-1, 3).This PR also adds a test for
read_asdfon rvint and pid data. Previously it was only being tested on pack9 data, which is why the tests didn't catch this.Fixes #164.