Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor if ale customizing to abstract class #39

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Refactor if ale customizing to abstract class #39

merged 3 commits into from
Oct 30, 2020

Conversation

Goala
Copy link
Member

@Goala Goala commented Oct 29, 2020

@Goala Goala requested a review from JohannesKonings October 29, 2020 13:24
@Goala Goala changed the title Refactor if ale customizing zo abstract class Refactor if ale customizing to abstract class Oct 29, 2020
JohannesKonings
JohannesKonings requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@JohannesKonings JohannesKonings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

JohannesKonings
JohannesKonings approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@JohannesKonings JohannesKonings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesKonings JohannesKonings linked an issue Oct 30, 2020 that may be closed by this pull request
Convert customizing interface to abstract class #30
Closed
@JohannesKonings JohannesKonings merged commit 14e22cf into master Oct 30, 2020
@Goala Goala deleted the refactor-ale-customizing branch October 30, 2020 09:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JohannesKonings JohannesKonings JohannesKonings approved these changes

Assignees

@JohannesKonings JohannesKonings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert customizing interface to abstract class
2 participants
@Goala @JohannesKonings