Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve copy action in object log dialog #270

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Improve copy action in object log dialog #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/dialogs/AbapGitDialogObjLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
import org.eclipse.swt.SWT;
import org.eclipse.swt.dnd.Clipboard;
import org.eclipse.swt.dnd.TextTransfer;
import org.eclipse.swt.events.KeyAdapter;
import org.eclipse.swt.events.KeyEvent;
import org.eclipse.swt.events.SelectionAdapter;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.graphics.Image;
Expand Down Expand Up @@ -69,6 +71,7 @@ public class AbapGitDialogObjLog extends TitleAreaDialog implements IResourceCha
private final Image successImage;
private final Image infoImage;
private Action actionCopy;
private Action actionCopyObjName;
private final static String ERROR_FLAG = "E"; //$NON-NLS-1$
private final static String WARNING_FLAG = "W"; //$NON-NLS-1$
private final static String INFO_FLAG = "I"; //$NON-NLS-1$
Expand Down Expand Up @@ -348,6 +351,15 @@ public String getText(Object element) {

hookContextMenu(this.abapObjTable);

this.abapObjTable.getTree().addKeyListener(new KeyAdapter() {
@Override
public void keyPressed(KeyEvent event) {
if ((event.stateMask & SWT.CTRL) != 0 && (event.keyCode == 'c' || event.keyCode == 'C')) {
copy();
}
}
});

createTableViewerColumn(Messages.AbapGitDialogImport_column_msg_type, 150).setLabelProvider(new ColumnLabelProvider() {
@Override
public String getText(Object element) {
Expand Down Expand Up @@ -481,12 +493,14 @@ private void fillContextMenu(IMenuManager manager) {
return;
}
menuManager.add(AbapGitDialogObjLog.this.actionCopy);
menuManager.add(AbapGitDialogObjLog.this.actionCopyObjName);
}
});

}

private void makeActions() {
//Generic action to copy row
this.actionCopy = new Action() {
public void run() {
copy();
Expand All @@ -496,6 +510,20 @@ public void run() {
this.actionCopy.setToolTipText(Messages.AbapGitView_action_copy);
this.actionCopy.setActionDefinitionId(ActionFactory.COPY.getCommandId());
this.actionCopy.setImageDescriptor(PlatformUI.getWorkbench().getSharedImages().getImageDescriptor(ISharedImages.IMG_TOOL_COPY));

//Action to copy object name
this.actionCopyObjName = new Action() {
public void run() {
Object firstElement = AbapGitDialogObjLog.this.tree.getViewer().getStructuredSelection().getFirstElement();
IAbapObject selectedAbapObj = (IAbapObject) firstElement;

final Clipboard clipboard = new Clipboard(AbapGitDialogObjLog.this.tree.getViewer().getControl().getDisplay());
clipboard.setContents(new String[] { selectedAbapObj.getName() }, new TextTransfer[] { TextTransfer.getInstance() });
clipboard.dispose();
}
};
this.actionCopyObjName.setText(Messages.AbapGitView_action_copy_obj_name);
this.actionCopyObjName.setToolTipText(Messages.AbapGitView_action_copy_obj_name);
}

@Override
Expand Down
1 change: 1 addition & 0 deletions org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/i18n/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public class Messages extends NLS {
public static String AbapGitView_action_clone;
public static String AbapGitView_action_refresh;
public static String AbapGitView_action_copy;
public static String AbapGitView_action_copy_obj_name;
public static String AbapGitView_action_showMyRepos;
public static String AbapGitView_action_open;
public static String AbapGitView_action_open_repo;
Expand Down
1 change: 1 addition & 0 deletions org.abapgit.adt.ui/src/org/abapgit/adt/ui/internal/i18n/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ AbapGitView_action_clone=Link New abapGit Repository...
AbapGitView_action_refresh=Refresh
AbapGitView_action_showMyRepos=My Repositories
AbapGitView_action_copy=Copy to Clipboard
AbapGitView_action_copy_obj_name=Copy Object Name
AbapGitView_action_open=Open Package
AbapGitView_action_open_repo=Open Repository in Browser
AbapGitView_action_open_repo_tooltip=Open Repository in Browser
Expand Down